Increase the GZip DeflaterOutputStream buffer size to increase performance #36818
Conversation
Summary of ChangesHello @scwhittle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the performance of GZip compression within the Apache Beam SDK by adjusting the buffer size used by GZIPOutputStream. By increasing the buffer from 512 bytes to 4096 bytes, the change aims to significantly speed up write operations, potentially by a factor of two, based on external benchmarks. This modification is expected to have a minimal impact on memory consumption, as other codecs already utilize larger buffers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
2 participants
The default buffer size is 512 bytes and this PR increases it to 4096.
Based upon benchmarks https://bugs.openjdk.org/secure/attachment/87709/InflaterOutputStreamWrite.java
from https://bugs.openjdk.org/browse/JDK-8242864
it is expected that this will decrease cpu of write by 2x. This cpu usage is 50% of cpu profiles of a streaming dataflow pipeline writing gzip files.
The buffers used for other codecs appear to be in megabytes, and the data written to files is generally much larger so I'm not particularly concerned about the memory increase.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.